Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up magellan event API #609

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Clean up magellan event API #609

merged 1 commit into from
Jan 12, 2017

Conversation

eile
Copy link
Member

@eile eile commented Jan 11, 2017

No description provided.

@eile eile force-pushed the master branch 2 times, most recently from 0e05735 to 1c16daf Compare January 11, 2017 11:32
tribal-tec
tribal-tec approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@tribal-tec tribal-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird code style mixture now, but your call.

Magellan event cleanup
6a55ac1 
Both magellan events don't need an event type, since there is only one
of them. Consistent with Statistic events, drop it.
@eile eile merged commit c79ce87 into Eyescale:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribal-tec tribal-tec tribal-tec approved these changes

Assignees

@tribal-tec tribal-tec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eile @tribal-tec