-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running from an installed version (Fix #618, Fix BlueBrain/Livre#379) #619
Conversation
Hold this horse - need to verify that plugins are loaded. |
…ing plugins into separate library (Eyescale#618)
Please shoot the horse now. |
Great! It works... Thanks. Just one detail. I need to integrate Livre in a QT app. I compiled Equalizer with QT support. I'm using distributed QT 5 devel packages. To make it compile I need to change a litlle bit QuickRenderer.cpp in Deflect line 50: #ifdef DEFLECT_USE_QT5GUI #include #endif and replace calls #if DEFLECT_USE_QT5GUI |
Can you please submit a pull request in Deflect with this change? |
@rdumusc FYI |
Yes, I'm already looking into this. The compilation error must be because the private headers are not installed and CMake did not catch it for some reason, despite the check that sets DEFLECT_USE_QT5GUI. This suggestion to forward-declare the function instead of including the private header looks reasonable as I discovered that it is how it is done internally in QtWebengine: Note that the above code should use qt_gl_set_global_share_context(QOpenGLContext* context) (setter) and not QOpenGLContext *qt_gl_global_share_context() (getter). I will submit a patch later today. |
No description provided.