Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag ECS resources and update maxTime for AWS resources #12

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

oscnord
Copy link
Contributor

@oscnord oscnord commented Apr 28, 2022

Fixes: #10 and #7

This PR updates the ECS task command to tag all resources with corresponding filename. This is to make it easier to cancel tasks in the future. The max wait time for MediaConvert and ECS tasks have also been updated to 8 hours from previously 1 hour. This should fix issues with monitoring of ECS tasks failing.

The LAMBDA environment variable have been renamed to LOAD_CREDENTIALS_FROM_ENV to better explain usage.

The @types/aws-sdk have been removed as a dependency because types are included in the aws-sdk.

@oscnord oscnord self-assigned this Apr 28, 2022
@oscnord oscnord linked an issue Apr 28, 2022 that may be closed by this pull request
@oscnord oscnord marked this pull request as ready for review April 28, 2022 10:44
This was referenced Apr 28, 2022
Copy link
Contributor

@jonathanwalter jonathanwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oscnord oscnord merged commit 38bed0d into main Apr 28, 2022
@oscnord oscnord deleted the feat/aws-waittimer branch April 28, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag AWS resources with filename Change LAMBDA env to something more relevant
2 participants