Skip to content

fix: add NACK for opus offer #15

fix: add NACK for opus offer

fix: add NACK for opus offer #15

Triggered via pull request September 18, 2023 16:47
Status Failure
Total duration 26s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 10 warnings
lint: src/adapters/WHEPAdapter.ts#L92
'opusCodecId' is never reassigned. Use 'const' instead
lint: src/adapters/WHEPAdapter.ts#L94
Insert `·`
lint: src/adapters/WHEPAdapter.ts#L95
Replace `"opus/48000/2\r\n",·"opus/48000/2\r\na=rtcp-fb:"+opusCodecId[1]+·"·nack\r\n")` with `⏎············'opus/48000/2\r\n',⏎············'opus/48000/2\r\na=rtcp-fb:'·+·opusCodecId[1]·+·'·nack\r\n'⏎··········);`
lint: src/adapters/WHEPAdapter.ts#L98
Delete `······`
lint: src/adapters/WHEPAdapter.ts#L264
Replace `response.status·===·406·&&·this.audio·&&·!this.mediaConstraints.audioOnly·&&·!this.mediaConstraints.videoOnly` with `⏎········response.status·===·406·&&⏎········this.audio·&&⏎········!this.mediaConstraints.audioOnly·&&⏎········!this.mediaConstraints.videoOnly⏎······`
lint: src/adapters/WHEPAdapter.ts#L271
Replace `response.status·===·406·&&·this.video·&&·!this.mediaConstraints.audioOnly·&&·!this.mediaConstraints.videoOnly` with `⏎········response.status·===·406·&&⏎········this.video·&&⏎········!this.mediaConstraints.audioOnly·&&⏎········!this.mediaConstraints.videoOnly⏎······`
lint: src/index.ts#L26
Insert `;`
lint: src/index.ts#L65
Replace `·...MediaConstraintsDefaults,·...opts.mediaConstraints` with `⏎······...MediaConstraintsDefaults,⏎······...opts.mediaConstraints⏎···`
lint
Process completed with exit code 1.
lint: demo/demo.ts#L92
'_' is assigned a value but never used
lint: src/adapters/Adapter.ts#L1
'DEFAULT_CONNECT_TIMEOUT' is assigned a value but never used
lint: src/adapters/AdapterFactory.ts#L24
'mediaConstraints' is defined but never used
lint: src/adapters/AdapterFactory.ts#L33
'mediaConstraints' is defined but never used
lint: src/adapters/EyevinnAdapter.ts#L9
Unexpected any. Specify a different type
lint: src/adapters/EyevinnAdapter.ts#L16
'onError' is defined but never used
lint: src/adapters/EyevinnAdapter.ts#L67
Unexpected any. Specify a different type
lint: src/adapters/EyevinnAdapter.ts#L73
Unexpected any. Specify a different type
lint: src/adapters/EyevinnAdapter.ts#L77
'event' is defined but never used
lint: src/adapters/WHEPAdapter.ts#L60
'opts' is defined but never used