-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of zone support #12
Conversation
Hello @Ezian , Also, it seems there is an offset issue with the current version, are you aware ? |
What do you mean ? Coordinate are correctly displayed in the main branch. Which offset do you are talking about ? |
Have a look to https://github.com/Ezian/hex-chronicle/blob/main/hexgrid-example.svg ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really enjoy to read this PR, thanks !
I have few feedback, mostly improvement.
Moreover, before merging, it would be great to add:
- Example in documentation (and documentation BTW)
- Regenerate the
hexgrid-example.svg
which is shown in the Readme.md.
I have in mind to write a Contribute.md file in order to explicit this rules.
Huho shit. I had introduce it when I take Pylint stuff in account... |
I've botched the compute of the grid.origin point... |
Fixed. |
I Recreate a MR to simplify Rebases.
This is a draft (yet effective) implementation for #3 .
What is done :
However there is still some issues :
Is it really a good idea to have Hexagon know it's grid? I would have expected the opposite. (In fact I half expected to see HexagonGrid implement the factory pattern to produce hexagon. (so that every Hexagon is registered in it's grid. )
@Ezian WDYT ?