Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring keybindings for TUI #22

Closed
thenonameguy opened this issue Nov 1, 2022 · 3 comments
Closed

Add support for configuring keybindings for TUI #22

thenonameguy opened this issue Nov 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@thenonameguy
Copy link
Contributor

The current keybinding is somewhat cumbersome on Fn Lock laptop keyboards (causing airplane mode to be hit instead Start 😄)
It would be nice if the process-compose.yml had some optional top-level action->keybind map that could override the current default bindings.

@F1bonacc1
Copy link
Owner

Hi @thenonameguy

Good suggestion, I planned some refactoring in that area in any case :)
However, I think process-compose.yml is not the correct place for personalization, since you might want to share your process-compose,yml with other developers.
What do you think about adding a .compose customization file to user's $HOME?

@thenonameguy
Copy link
Contributor Author

thenonameguy commented Nov 1, 2022

If anything it should be $XDG_CONFIG_HOME , but I much prefer explicit CLI flags so I can decide where I want to host it/template it with an env var.

I would argue that having everything in a process-compose.yml is preferable so that the complete behavior of the runtime is described by it, without anything implicit polluting from the user environment. I guess I'm a purist :)

Alternatively, I'm sometimes longing for docker-compose's deep-merge behavior of yml files:
https://docs.docker.com/compose/reference/#specifying-multiple-compose-files

With this you could solve the per-user keybind problem like:

process-compose -f process-compose.yml -f process-compose.$USER.yml

While also solving the pretty obvious usual BE/FE service split:

## backenders run
process-compose -f process-compose.be.yml
## frontenders run with fe depending on services defined in be
process-compose -f process-compose.be.yml -f process-compose.fe.yml

@F1bonacc1 F1bonacc1 added the enhancement New feature or request label Nov 4, 2022
@F1bonacc1
Copy link
Owner

Hi @thenonameguy

v0.24.0
Should prevent the airplane mode once and for all 😃

BTW it would be great if you could share your new configuration.

adrian-gierakowski pushed a commit to rhinofi/process-compose that referenced this issue Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants