Clustering trust_domain is broken due to api changes in tm.sys.application #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm.sys.application Issues: Fixes F5Networks#521 Problem: The clustering module trust_domain.py is broken because the api changed for tm.sys.applications to tm.sys.application. I will fix the issue and submit the fix, and we'll have to spin another release to remedy this. Analysis: Modified the references to applications in trust_domain.py and reran the clustering tests. Tests: Clustering tests passed locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zancas
Issues:
Fixes #521
Problem:
The clustering module trust_domain.py is broken because the api changed
for tm.sys.applications to tm.sys.application. I will fix the issue and
submit the fix, and we'll have to spin another release to remedy this.
Analysis:
Modified the references to applications in trust_domain.py and reran the
clustering tests.
Tests:
Clustering tests passed locally.