Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Git flow is fun! #17

Open
veredrec opened this issue Nov 21, 2017 · 2 comments
Open

Git flow is fun! #17

veredrec opened this issue Nov 21, 2017 · 2 comments

Comments

@veredrec
Copy link

Overall, your github flow is nice 🎉

issues
I love the titles and descriptions for your issues, they show what you are working on, which is great! Don't forget to open an issue for every feature/part of code you are working on.

commits
You almost always reference an issue when you commit changes, which is great! ✨
Don't forget that if you don't have an issue, you can open one before you commit your changes, but of course the best option is to create an issue before starting to work on something.

pull requests
Your pull requests have better titles and descriptions, and most of them reference an issue. Try to assigns your team members as reviewers, so all of you go over the code before merging it. This is your chance to approve ✅ request changes ✖️ or ask any question about the code ❓
Please don't make any changes on master 😱 even if it seems like a small change. Every change should come from your code editor and terminal.

contributions
Try to aim to split the work evenly between all of the team members. You can see the current graph here.
You can do it by making sure you swap roles and laptops all the time ⏲️

Keep up the good work! 😄

@Amirk390
Copy link
Collaborator

Amirk390 commented Nov 22, 2017

Thanks Vered for the great feed back! 😄
Helpful tips!
We gonna try our best to improve our working style even more 👍

@prodionov @hoslack @ghassanmas

@hoslack
Copy link
Member

hoslack commented Nov 22, 2017

Thanks Vared!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants