Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load view before showing replay #2100

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

1-alex98
Copy link
Member

@1-alex98 1-alex98 commented Jan 4, 2021

Fixes #2099

@@ -247,7 +247,6 @@ protected void onPageChange(SearchConfig searchConfig, boolean firstLoad) {

protected void displaySearchResult(List<T> results) {
JavaFxUtil.assertBackgroundThread();
enterSearchingState();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was just called a second time and was on the backgroup thread

@Sheikah45
Copy link
Member

Hmm it is failing some tests

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2100 (3f57408) into develop (98db90d) will increase coverage by 1.50%.
The diff coverage is 74.48%.

@@              Coverage Diff              @@
##             develop    #2100      +/-   ##
=============================================
+ Coverage      50.18%   51.69%   +1.50%     
- Complexity      3261     3392     +131     
=============================================
  Files            557      557              
  Lines          19141    19201      +60     
  Branches        1106     1112       +6     
=============================================
+ Hits            9606     9925     +319     
+ Misses          8992     8738     -254     
+ Partials         543      538       -5     
Impacted Files Coverage Δ Complexity Δ
...a/com/faforever/client/api/FafApiAccessorImpl.java 41.96% <0.00%> (ø) 34.00 <0.00> (ø)
...aforever/client/map/generator/GenerateMapTask.java 12.12% <0.00%> (-0.79%) 2.00 <0.00> (ø)
...main/java/com/faforever/client/mod/ModVersion.java 57.40% <0.00%> (+11.07%) 57.00 <0.00> (+12.00)
...aforever/client/vault/review/ReviewController.java 1.42% <0.00%> (-0.03%) 1.00 <0.00> (ø)
src/main/java/com/faforever/client/mod/Mod.java 51.72% <33.33%> (+25.86%) 12.00 <0.00> (+8.00)
...ever/client/map/generator/MapGeneratorService.java 61.73% <50.00%> (-0.43%) 15.00 <0.00> (ø)
.../main/java/com/faforever/client/replay/Replay.java 47.42% <50.00%> (+17.54%) 31.00 <0.00> (+9.00)
...m/faforever/client/preferences/GeneratorPrefs.java 81.81% <80.00%> (-0.64%) 33.00 <8.00> (+8.00) ⬇️
...aforever/client/replay/ReplayDetailController.java 94.68% <81.25%> (+28.86%) 43.00 <2.00> (+20.00)
...ver/client/replay/OnlineReplayVaultController.java 80.21% <83.33%> (+4.27%) 25.00 <0.00> (+5.00)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98db90d...f6a4a1b. Read the comment docs.

@Sheikah45 Sheikah45 merged commit c1f6b0f into develop Jan 7, 2021
@Sheikah45 Sheikah45 deleted the bugfix/#2099-load-viiew-before-showing-replay branch January 12, 2021 01:24
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load view before showing replay
3 participants