-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load view before showing replay #2100
Load view before showing replay #2100
Conversation
@@ -247,7 +247,6 @@ protected void onPageChange(SearchConfig searchConfig, boolean firstLoad) { | |||
|
|||
protected void displaySearchResult(List<T> results) { | |||
JavaFxUtil.assertBackgroundThread(); | |||
enterSearchingState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was just called a second time and was on the backgroup thread
Hmm it is failing some tests |
Codecov Report
@@ Coverage Diff @@
## develop #2100 +/- ##
=============================================
+ Coverage 50.18% 51.69% +1.50%
- Complexity 3261 3392 +131
=============================================
Files 557 557
Lines 19141 19201 +60
Branches 1106 1112 +6
=============================================
+ Hits 9606 9925 +319
+ Misses 8992 8738 -254
+ Partials 543 538 -5 Continue to review full report at Codecov.
|
Fixes #2099