-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table allocation free versions of sim commands #5436
Merged
Garanas
merged 10 commits into
deploy/fafdevelop
from
performance/issue-move-off-factory
Sep 19, 2023
Merged
Table allocation free versions of sim commands #5436
Garanas
merged 10 commits into
deploy/fafdevelop
from
performance/issue-move-off-factory
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick-and-dirty benchmark: local start = GetSystemTimeSecondsOnlyForProfileUse()
for k = 1, 1000 do
local arr = {self}
end
local diff = (GetSystemTimeSecondsOnlyForProfileUse() - start) * 1000
LOG("New table: " .. tostring(diff)) -- 0.12 ms
local start = GetSystemTimeSecondsOnlyForProfileUse()
local cached = { }
for k = 1, 1000 do
cached[1] = self
end
local diff = (GetSystemTimeSecondsOnlyForProfileUse() - start) * 1000
LOG("Reused table: " .. tostring(diff)) -- 0.015 ms Where |
Garanas
changed the title
Table allocation free version of
Table allocation free versions of sim commands
Sep 15, 2023
IssueMoveOffFactory
@Hdt80bro would you have time to go over the changes, see if I did a hiccup anywhere? |
Garanas
added a commit
that referenced
this pull request
Sep 23, 2023
clyfordv
pushed a commit
to clyfordv/fa
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This idea started with #5398 where we introduce alternatives to global functions that work for just a single unit, instead of a group of units. The goal is to prevent the allocation of a table with a single array entry in it when we need to apply the function to a single unit.
We can apply the same approach to the simulation. We introduce alternatives that work on a single unit and re-use a single table to efficiently manage memory without the developer being aware of it.