-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Hotbuild to redirect orders to exfac units like the buttons do #5656
Allow Hotbuild to redirect orders to exfac units like the buttons do #5656
Conversation
factory templates are kinda broken in normal hotbuild and a bit more broken for exfac units
@4z0t can you take the time to review this? I generally do not use hotkeys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow DRY
@4z0t |
There's no need to write a separate function for that if statement. If you can apply the Pascal convention to the name of the function today then we can include it with the hotfix |
I changed the name of the new function, though all other functions in that file are still lowerCamelCase |
Tested and works. The only thing that does appear to be missing, is that the automatic enabling of repeat build does not work. To remedy this, you can add |
@gordenwunderlich can you look at fixing what Basalisk mentions? |
@MrRowey that can be fixed separately from this pull request. |
Forged.Alliance.2023-11-10.16-09-34.mp4
should work for both normal and alternate hotbuild (templates not yet)
Needs more testing since I just quickly copied the code from @clyfordv but I wanted to at least put this out there.