Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Siren REPAIR category #6007

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Remove Siren REPAIR category #6007

merged 2 commits into from
Mar 20, 2024

Conversation

Hdt80bro
Copy link
Contributor

Currently, the Siren Class cruiser has the REPAIR category - presumably because it's an air staging platform that can repair aircraft. What this actually does is let it repair other units like an engineer, despite having no visual indication or defined build rate - it defaults to 1 and is incredibly slow. If this was intended, it would have been more clear with an appreciable build rate and effect (maybe even an animation, unit description line, or unit ability), but given the context, it appears to be a simple oversight.

image
Notice the orange progress bar and 1 power drain - the damaged cruiser used to be at 30% health but is now at 32%

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an old screenshot; units with an undefined buildrate are postprocessed to 0.

-- Override the default 1 build rate given to units
-- so that rollover unit view can work with Mantis.
if unit.Economy and not unit.Economy.BuildRate then
unit.Economy.BuildRate = 0
end

Even with 0 buildrate the Siren still tries to repair, not moving into formation and displaying the work progress bar, so it's good to remove the category for that reason too.

@lL1l1 lL1l1 merged commit ea0f220 into deploy/fafdevelop Mar 20, 2024
3 checks passed
@lL1l1 lL1l1 deleted the remove-siren-repair branch March 20, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants