Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Mongoose and Hoplite to fire from transports #6073

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Apr 12, 2024

Description of the proposed changes

Makes the small bp changes needed for the units to work in transports. Hoplite has its attachpoint bone parented to the Torso instead of the Turret bone so that it can rotate its turret while in a transport.

Testing done on the proposed changes

Loaded the units into transports and made sure they can fire in all directions. Since Hoplite's bones were changed, I also paid attention to its loading/unloading animations and found no new issues.
I also tried making a version where the Hoplite loaded upside-down into the transport, so that it wouldn't look as bad, but it had bone-snapping issues when loading, and would fall through the ground and die when unloading.

Checklist

- [ ] Changes are annotated, including comments where useful N/A

  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: balance idea related to suggestions for unit balance label Apr 12, 2024
@MrRowey MrRowey added this to the Balance Iteration I of 2024 milestone Apr 12, 2024
@MrRowey MrRowey added the DO NOT MERGE Don't Merge until removed label Apr 12, 2024
@MrRowey MrRowey merged commit 1be5150 into FAForever:deploy/fafdevelop Apr 12, 2024
@Garanas
Copy link
Member

Garanas commented Apr 12, 2024

I'm not certain if I'm a fan of how the Hoplite behaves in a transport. Yes it shoots. But visually it looks odd:

  • It is attached to the turret, but somehow it can manage to rotate the turret to aim
  • When the turret aims while in the transport it self-intersects with the rest of the mesh
  • It is attached, but appears to have a larger distance between the transport and the Hoplite than before

An alternative solution may be to adjust the (un)load animation, but I'm not fully certain how to make it look better even if we did. The way the Hoplite works makes it unnatural.

image

@solismortis
Copy link
Contributor

I'm not certain if I'm a fan of how the Hoplite behaves in a transport. Yes it shoots. But visually it looks odd:

  • It is attached to the turret, but somehow it can manage to rotate the turret to aim
  • When the turret aims while in the transport it self-intersects with the rest of the mesh
  • It is attached, but appears to have a larger distance between the transport and the Hoplite than before

An alternative solution may be to adjust the (un)load animation, but I'm not fully certain how to make it look better even if we did. The way the Hoplite works makes it unnatural.

image

In Nomads, they made Nomads labs turn upside down for their turrets to shoot down.

@lL1l1 lL1l1 removed the DO NOT MERGE Don't Merge until removed label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance idea related to suggestions for unit balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants