Fix issues with fire rate test related to rounding tie-breaking towards evens #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes fire rate interval from 13 ticks to 12. CZAR SAMs, Pillar, Cyb cruiser AA, Megalith cannons
10/1.25 = 8 so it was already fine
lL1l1
added
type: bug
area: automated testing
Garanas
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Fixes the fire rate test to account for banker's rounding (tie break towards even numbers), and corrects erroneous fire rate changes from #5845.
Testing done on the proposed changes
Set my ACU's fire rate to 4/0.8 and added a log statement when the projectile is created to make sure it fires every 2/12 ticks.
Checklist