Polish area attack dragger code and visuals #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lL1l1
added
area: ui
Garanas
reviewed
Jul 1, 2024
| @@ -51,9 +45,8 @@ end | |||
|
|
|||
| ---@param units Unit[] | |||
| ---@param target Vector | |||
| ---@param doPrint boolean # if true, prints information about the order | |||
| ---@param radius? number | |||
| function AreaAttackOrder(units, target, doPrint, radius) | |||
There was a problem hiding this comment.
The printing was not used (yet), but in general the printing exists as a form of feedback for the user that the command is processed. I'm fine with it (not) existing, but that's why all the other special commands (distribute/copy orders, assist-to side effects, etc) have this printing.
Garanas
approved these changes
Jul 1, 2024
lL1l1
force-pushed
the
feature/area-attack-dragger
branch
from
a54034e
to
7202fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Builds on top of/contains #6312 and #6316 (rebase this PR when those are merged in).
Testing done on the proposed changes
Use the area attack order by clicking and dragging and make sure it looks good.
Checklist