Add request id context to logging and error responses #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
feature/request-logging
branch
from
544c677
to
e44c04e
Compare
bukajsytlos
reviewed
May 6, 2019
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| @Data | ||
| public class ErrorResponse { | ||
| private final String requestId; |
There was a problem hiding this comment.
why dont we leave it as response header?
There was a problem hiding this comment.
That's probably my personal preference. As part of the payload I have it immediately available e.g. when deserializing the message with a Spring RestTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each http request creates a request id (either from nginx or random uuid).
This request id is then applied to every log message during processing until the http request is finished, then it is cleaned up.
Furthermore the request id is added to each error message the API sends back to the client. So the user has an id that he can give on error reports to check the related logs.