Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the MacSigner with RsaSigner/RsaVerifier. (fixes #318) #323

Merged
merged 2 commits into from
Mar 1, 2020

Conversation

Brutus5000
Copy link
Member

This allows us to hand out the public key to other services. Especially
the JWT needs to be verified by the lobby server to get rid of multiple
services accessing the user passwords.

1-alex98
1-alex98 previously approved these changes Jul 17, 2019
@Brutus5000
Copy link
Member Author

Need to figure out, why the integration tests fail :(

This allows us to hand out the public key to other services. Especially
the JWT needs to be verified by the lobby server to get rid of multiple
services accessing the user passwords.
@Brutus5000 Brutus5000 force-pushed the feature/#318-rsa-token-signing branch 2 times, most recently from 83a6482 to d162bd3 Compare February 8, 2020 22:40
@Brutus5000 Brutus5000 force-pushed the feature/#318-rsa-token-signing branch from d162bd3 to 7516ebe Compare February 9, 2020 13:31
@Brutus5000 Brutus5000 merged commit 3728ec8 into develop Mar 1, 2020
@Brutus5000 Brutus5000 deleted the feature/#318-rsa-token-signing branch March 28, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants