Fixes Data type mismatch issue on LeaderBoard

[padmano]

#302

[padmano]

@Brutus5000 Can you help me out with this ?

[Brutus5000]

@iamTheL If you rebase on develop it will be fixed.
That's a nasty circular dependency in our release process.

[1-alex98]

Maybe with Brackets. I actually just read your guidelines and I can not find anything on that but we like to keep code style alike.

[padmano]

Have added the brackets for the if-else block. Still it seems to be failing.

[1-alex98]

What is failing?

[padmano]

I am not able to find out what is causing the test coverage to drop.

[1-alex98]

Well if u add more lines without writing tests the coverage increases so if u write new stuff(like u did) test it. Make a unit test feed the Service a string and see if it throws the Exception u expected...

[1-alex98]

https://reqtest.com/testing-blog/test-coverage-metrics/

[padmano]

Got it. Will write tests and submit again.

[1-alex98]

your suggested fix does not work.(tested it)

This should also be way more compact.

if(!StringUtils.isNumeric(playerId)){
      throw new ApiException(new Error(ErrorCode.PLAYER_ID_MUST_BE_NUMBER));
}

And use StringUtils from Apache that is it basically.

[padmano]

@axel1200 I went ahead with your suggestion.

wait

[1-alex98]

I am sorry to annoy you further but this would be a something that can be easily tested, either unit or integration test. Does not really matter.

[Brutus5000]

Got superseeded by #372 as we replaced the whole exception.