Migrate tests to junit 5 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included compile & runtime classpath for running integration tests with dependencies Included dependency for enable working old annotations from Junit4 (Rule, ExpectedException and ExternalResource)
Included Mockito extensions + JUnit extensions for working with JUnit5 Refactored few tests that do not need to create some stubs (Mockito throws some UnnecessaryStubbingException) Replaced some duplicated stubs with chainable calls (ex: VotingServiceTest)
|
The broken pipeline seems to be caused by Travis CI changes. For some reason the JDK11 compiler is used while it was JDK8 a few days ago 😦 |
|
About the build, it seems Oracle JDK 9 is discontinued in Travis CI. |
|
If you add |
# Conflicts: # src/inttest/java/com/faforever/api/data/BanTest.java # src/inttest/java/com/faforever/api/data/DomainBlacklistTest.java # src/inttest/java/com/faforever/api/data/Ladder1v1MapTest.java # src/inttest/java/com/faforever/api/data/MapVersionElideTest.java # src/inttest/java/com/faforever/api/data/TeamkillTest.java # src/inttest/java/com/faforever/api/data/UserNoteTest.java
Brutus5000
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.