Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide 6.0 #544

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Elide 6.0 #544

merged 1 commit into from
Feb 12, 2022

Conversation

bukajsytlos
Copy link
Member

Closes #543

@bukajsytlos bukajsytlos force-pushed the feature/#543-elide6 branch 3 times, most recently from aae3d8f to f712a00 Compare January 30, 2022 13:28
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #544 (d252722) into develop (d61b486) will increase coverage by 0.11%.
The diff coverage is 90.90%.

@@              Coverage Diff              @@
##             develop     #544      +/-   ##
=============================================
+ Coverage      75.71%   75.82%   +0.11%     
- Complexity      1124     1125       +1     
=============================================
  Files            240      240              
  Lines           3574     3570       -4     
  Branches         224      224              
=============================================
+ Hits            2706     2707       +1     
+ Misses           777      772       -5     
  Partials          91       91              
Impacted Files Coverage Δ
...r/api/config/elide/SpringHibernateTransaction.java 76.47% <50.00%> (-3.53%) ⬇️
.../com/faforever/api/config/FafDatasourceConfig.java 100.00% <100.00%> (ø)
...m/faforever/api/config/LeagueDatasourceConfig.java 100.00% <100.00%> (ø)
...va/com/faforever/api/config/elide/ElideConfig.java 88.88% <100.00%> (+0.88%) ⬆️
...ver/api/config/elide/SpringHibernateDataStore.java 100.00% <100.00%> (+6.89%) ⬆️
...a/com/faforever/api/data/checks/BooleanChange.java 26.66% <0.00%> (+6.66%) ⬆️
...com/faforever/api/data/checks/IsAuthenticated.java 33.33% <0.00%> (+33.33%) ⬆️
...i/security/elide/permission/WriteMessageCheck.java 33.33% <0.00%> (+33.33%) ⬆️
.../security/elide/permission/WriteNewsPostCheck.java 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61b486...d252722. Read the comment docs.

@bukajsytlos bukajsytlos force-pushed the feature/#543-elide6 branch 3 times, most recently from 4151047 to 52ebd48 Compare January 31, 2022 07:20
@Brutus5000 Brutus5000 merged commit 69dd45d into develop Feb 12, 2022
@Brutus5000 Brutus5000 deleted the feature/#543-elide6 branch February 12, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Elide 6
2 participants