Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new league columns #580

Merged

Conversation

BlackYps
Copy link
Contributor

@BlackYps BlackYps commented Apr 3, 2022

Adds support for tracking of veteran players to place them earlier than new players

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #580 (b187b60) into develop (b2eeb1e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop     #580      +/-   ##
=============================================
+ Coverage      75.84%   75.85%   +0.01%     
- Complexity      1139     1141       +2     
=============================================
  Files            239      239              
  Lines           3610     3612       +2     
  Branches         231      231              
=============================================
+ Hits            2738     2740       +2     
  Misses           776      776              
  Partials          96       96              
Impacted Files Coverage Δ
.../com/faforever/api/league/domain/LeagueSeason.java 100.00% <100.00%> (ø)
...faforever/api/league/domain/LeagueSeasonScore.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2eeb1e...b187b60. Read the comment docs.

Copy link
Member

@bukajsytlos bukajsytlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Brutus5000 Brutus5000 merged commit 3d2c557 into FAForever:develop Apr 4, 2022
@BlackYps BlackYps deleted the feature/league-service-update branch April 4, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants