Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms of service and fix some local profile run config #613

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #613 (ed430e2) into develop (2e09dd5) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop     #613      +/-   ##
=============================================
+ Coverage      75.85%   75.87%   +0.01%     
  Complexity      1141     1141              
=============================================
  Files            239      239              
  Lines           3612     3610       -2     
  Branches         231      230       -1     
=============================================
- Hits            2740     2739       -1     
+ Misses           776      775       -1     
  Partials          96       96              
Impacted Files Coverage Δ
...m/faforever/api/deployment/ExeUploaderService.java 93.75% <75.00%> (+2.32%) ⬆️
...om/faforever/api/config/swagger/SwaggerConfig.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e09dd5...ed430e2. Read the comment docs.

Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test emails should be minimal dummies and contain info how to generate html out of mjml

bukajsytlos
bukajsytlos previously approved these changes Jun 1, 2022
Copy link
Member

@bukajsytlos bukajsytlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I second, that test email could be simpler

@Sheikah45
Copy link
Member Author

I don't know what info is important to generate html out of mjml @Brutus5000 do you have a small sample you built from?

@Brutus5000
Copy link
Member

HTML is not important for the test sample, all you want is the app to launch.

It should:

  • contain all variables available for that file
  • contain a text like: "To generate proper html code use the template in src/main/mjml with an mjml parser (e.g. use the IntelliJ plugin for MJML or follow the instructions on https://documentation.mjml.io/#usage")

@Sheikah45
Copy link
Member Author

Alright I minimized it all

Copy link
Member

@bukajsytlos bukajsytlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Brutus5000 Brutus5000 merged commit a66a7f1 into develop Jun 7, 2022
@Brutus5000 Brutus5000 deleted the feature/terms-of-service branch June 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants