-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terms of service and fix some local profile run config #613
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #613 +/- ##
=============================================
+ Coverage 75.85% 75.87% +0.01%
Complexity 1141 1141
=============================================
Files 239 239
Lines 3612 3610 -2
Branches 231 230 -1
=============================================
- Hits 2740 2739 -1
+ Misses 776 775 -1
Partials 96 96
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test emails should be minimal dummies and contain info how to generate html out of mjml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I second, that test email could be simpler
I don't know what info is important to generate html out of mjml @Brutus5000 do you have a small sample you built from? |
HTML is not important for the test sample, all you want is the app to launch. It should:
|
Alright I minimized it all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.