-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cacheable URLs for FeatureModFiles #638
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #638 +/- ##
=============================================
+ Coverage 76.19% 76.25% +0.05%
- Complexity 1162 1166 +4
=============================================
Files 244 245 +1
Lines 3684 3693 +9
Branches 232 232
=============================================
+ Hits 2807 2816 +9
Misses 780 780
Partials 97 97
Continue to review full report at Codecov.
|
Mac mac = Mac.getInstance(HMAC_SHA256); | ||
mac.init(new SecretKeySpec(secret.getBytes(StandardCharsets.UTF_8), HMAC_SHA256)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be done on initializing the bean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good point
@Brutus5000 is this good now? |
This adds separation of the hmac token, param, and a cacheable url so that clients can send the hmac verification as a request header which allows caching of the request in cloudflare since there is no longer any query parameters