Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command invalid when db is down #800

Closed
Sheikah45 opened this issue Jun 26, 2021 · 3 comments · Fixed by #1009
Closed

Command invalid when db is down #800

Sheikah45 opened this issue Jun 26, 2021 · 3 comments · Fixed by #1009
Labels
bug good first issue

Comments

@Sheikah45
Copy link
Member

Sheikah45 commented Jun 26, 2021 •
edited
Loading

When the database is down and someone tries to login the error message from the server for why it fails claims that the command is invalid rather than saying the server can't reach the db.

It would probably be good to change this just for debugging purposes
@Askaholic Askaholic added the bug label Jul 31, 2021
@KaukaHan
Copy link
Contributor

KaukaHan commented Mar 9, 2022

nowdays without the database the devserver crashes.

@Askaholic
Copy link
Collaborator

You'd probably have to start the devserver while the database is up and then take the database down to reproduce this.

@benjamin-lawson benjamin-lawson mentioned this issue Mar 6, 2024
Merged
@benjamin-lawson
Copy link
Contributor

benjamin-lawson commented Mar 6, 2024 •
edited
Loading

@Askaholic Could you review my PR when you get the chance? All actions are passing including the unit test that I added.

Askaholic pushed a commit that referenced this issue Apr 20, 2024
@benjamin-lawson
Issue #800 - Invalid Command Response on Database Outage (#1009)
6312b1e 
* Add graceful error handling for database outages

* Add abort to OperationalError handling

* Add unit tests for OperationalError handling in lobbyconnection

* Replace apostrophe string with double quotes string

* Fix unit test to pass

* Fix Flake8 warnings

* Rerun actions

* Add logging when OperationalError is raised

* Fix linting issues

* Fix linting issues pt2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #800 - Invalid Command Response on Database Outage benjamin-lawson/faf-server
4 participants
@benjamin-lawson @Askaholic @KaukaHan @Sheikah45