Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/#730 ignore score results #731

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Issue/#730 ignore score results #731

merged 2 commits into from
Mar 6, 2021

Commits on Mar 5, 2021

  1. Add tests for draw bug

    @Askaholic
    Askaholic committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    173518b View commit details
    Browse the repository at this point in the history

  2. Refactor GameOutcome enum into several enums 

    We can now distinguish between results in their various stages:
1. Results reported by an individual for a specific army
2. Accepted result for an army based on the individual reports
3. Accepted result for the whole team based on the accepted army results

For instance, it doesn't make sense for a player's game to report the 
status
of a particular result as "conflicting" since conflicts only arise when
multiple players report different results for the same army. The Enum's 
now
reflect that, and you can no longer report a "conflicting" or "unknown"
result directly (as you could have before).

As a consequence, any result string that is not present in the
ArmyReportedOutcome will be ignored. Hence, the ACU kills reported via 
"score"
results will no longer affect the army score calculation (previously 
these
could turn a -10 score from a defeat into a positive number if the 
player got
any acu kills).
    @Askaholic
    Askaholic committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    20cadcc View commit details
    Browse the repository at this point in the history