Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solace projectile path typo causes damage calculation error #98

Closed
alex-kde opened this issue Nov 24, 2022 · 1 comment
Closed

Solace projectile path typo causes damage calculation error #98

alex-kde opened this issue Nov 24, 2022 · 1 comment

Comments

@alex-kde
Copy link

alex-kde commented Nov 24, 2022

The capitalisation on https://github.com/FAForever/spooky-db/blob/master/app/js/UnitDecorator.js#L161 is incorrect, leading to the Solace's damage to be listed as only 2000, i.e half the correct value, since the loop that checks for splitting projectiles misses this so doesn't account for the projectile splitting in two. The dps is also half the correct value.

The correct form is:
'/projectiles/AANTorpedoCluster01/AANTorpedoCluster01_proj.bp'

To demonstrate,
link to faf github with new spelling:
https://github.com/FAForever/fa/blob/develop/projectiles/AANTorpedoCluster01/AANTorpedoCluster01_proj.bp

link with current spelling: (404 error)
https://github.com/FAForever/fa/blob/develop/projectiles/aantorpedocluster01/aantorpedocluster01_proj.bp

It's also easy to verify when compared to the previous lines where the first letters of words, and the 3-letter code at the start are capitalised.

spooky added a commit that referenced this issue Nov 26, 2022
@spooky
Copy link
Collaborator

spooky commented Nov 26, 2022

Fixed. Thx for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants