Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: remove epoch arg from validate #261

Merged
merged 1 commit into from
Sep 1, 2021
Merged

bugfix: remove epoch arg from validate #261

merged 1 commit into from
Sep 1, 2021

Conversation

mshuaibii
Copy link
Collaborator

Re #260 - Post-merge change: validate no longer takes epoch as an argument. This was resolved for forces_trainer but not energy_trainer.

abhshkdz
abhshkdz approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@abhshkdz abhshkdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshuaibii mshuaibii merged commit e6d03e2 into master Sep 1, 2021
@mshuaibii mshuaibii deleted the etrainer_bugfix branch September 1, 2021 20:40
@mshuaibii mshuaibii mentioned this pull request Sep 1, 2021
Closed
levineds pushed a commit that referenced this pull request Jul 11, 2024
@mshuaibii
bugfix: remove epoch arg from validate (#261)
9b24624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuroopsriram anuroopsriram anuroopsriram approved these changes

@abhshkdz abhshkdz abhshkdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshuaibii @abhshkdz @anuroopsriram