Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Port not Local URL on init #141

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Conversation

kzscisoft
Copy link
Collaborator

Setting the local URL has no effect within the CLI, more significant is setting which port to run the registry on which has replaced the query within the initialise function.

@kzscisoft kzscisoft added the enhancement New feature or request label Nov 26, 2021
@kzscisoft kzscisoft added this to the v0.3 Release milestone Nov 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #141 (fd5f30c) into develop (3874f52) will decrease coverage by 0.04%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #141      +/-   ##
===========================================
- Coverage    73.38%   73.33%   -0.05%     
===========================================
  Files           24       24              
  Lines         3006     3038      +32     
===========================================
+ Hits          2206     2228      +22     
- Misses         800      810      +10     
Impacted Files Coverage Δ
fair/configuration.py 71.03% <73.07%> (-0.57%) ⬇️
fair/registry/server.py 82.32% <80.00%> (-0.46%) ⬇️
fair/session.py 64.00% <84.61%> (+0.10%) ⬆️
fair/cli.py 54.77% <100.00%> (+0.14%) ⬆️
fair/common.py 95.06% <100.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3874f52...fd5f30c. Read the comment docs.

@kzscisoft kzscisoft merged commit 30f217d into develop Nov 26, 2021
@kzscisoft kzscisoft deleted the kzscisoft/set-port-on-init branch November 26, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant