Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples after mpes refactor #35

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Update examples after mpes refactor #35

merged 10 commits into from
Apr 11, 2024

Conversation

lukaspie
Copy link
Collaborator

No description provided.

@lukaspie lukaspie requested review from domna and removed request for domna April 11, 2024 13:53
@lukaspie lukaspie marked this pull request as draft April 11, 2024 13:57
@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8649823152

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 64.514%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools_xps/reader.py 3 4 75.0%
Totals Coverage Status
Change from base Build 8567922651: 0.01%
Covered Lines: 2198
Relevant Lines: 3407
💛 - Coveralls

@lukaspie lukaspie requested a review from domna April 11, 2024 15:20
@lukaspie lukaspie marked this pull request as ready for review April 11, 2024 15:20
domna
domna requested changes Apr 11, 2024
View reviewed changes
pynxtools_xps/config/config_txt_vamas_export.json Outdated Show resolved Hide resolved
pynxtools_xps/config/config_txt_vamas_export.json Outdated Show resolved Hide resolved
pynxtools_xps/config/config_vms.json Show resolved Hide resolved
@lukaspie
Copy link
Collaborator Author

@domna thanks for the review, I addressed all your comments.

@lukaspie lukaspie merged commit 35baae6 into main Apr 11, 2024
6 checks passed
@lukaspie lukaspie deleted the update-examples-after-mpes-refactor branch April 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaspie @coveralls @domna