Don't emit "FOR UPDATE .." On SQLite #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just ignore it like it does for other things it doesn't implement, SQLite throws an error with 'FOR UPDATE' on a select statement. This just over-rides with an implementation that doesn't emit anything if there is a '.for'. The test just checks it doesn't explode with .skip-update, I've confirmed the SQL generated for both Pg and SQLite visually.
FCO
approved these changes
Apr 15, 2024
|
Thank you very much! |
|
I'll do a new release tomorrow (depending on the time I wake up it will be in n the morning or after work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just ignore it like it does for other things it doesn't implement, SQLite throws an error with 'FOR UPDATE' on a select statement.
This just over-rides with an implementation that doesn't emit anything if there is a '.for'.
The test just checks it doesn't explode with .skip-update, I've confirmed the SQL generated for both Pg and SQLite visually.
Fixes the #576