Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Freesurfer-Ingress without data config #2086

Open
1 task
nx10 opened this issue Mar 25, 2024 · 0 comments
Open
1 task

✨ Freesurfer-Ingress without data config #2086

nx10 opened this issue Mar 25, 2024 · 0 comments

Comments

@nx10
Copy link
Contributor

nx10 commented Mar 25, 2024

Related problem

I am running a large batch of different pipeline configs, some of which will be re-using freesurfer ingress-ed data between them.

Right now freesurfer ingress can only be used when also using a data config file (docs) and modifying both of them which over-complicates this process a little.

Building scripts for each subject-session combination in a large dataset requires to copy around the following paths:

graph TD
    a[BIDS subject-session]
    t[T1w]
    b[BOLD]
    f[Freesurfer CLI]
    d[C-PAC data config]
    p[C-PAC pipeline config]
    c[C-PAC CLI]

    a --> t
    a --> b
    t --> f
    t --> d
    f --> d
    b --> d
    d --> c
    p --> c
    a -.->|Unused but need to\n specify because of BIDS App| c

Loading

Proposed feature

It would be nice if C-PAC would accept a command line flag (e.g. --ingress-freesurfer [PATH]) and would find the rest of the data in the BIDS input dir as usual instead of having to supply an extra data config.

This would simplify the graph to this:

graph TD
    a[BIDS subject-session]
    t[T1w]
    f[Freesurfer CLI]
    p[C-PAC pipeline config]
    c[C-PAC CLI]

    a --> t
    t --> f
    f --> c
    p --> c
    a --> c

Loading

Acceptance criteria

  • Data configs does not need to be created to use freesurfer ingress

Alternatives

No response

Additional context

No response

@sgiavasis sgiavasis moved this to 🔖 Ready/Next in C-PAC Development Mar 25, 2024
@e-kenneally e-kenneally self-assigned this Mar 26, 2024
@sgiavasis sgiavasis moved this from 🔖 Ready/Next to 👀 In review in C-PAC Development Apr 25, 2024
@sgiavasis sgiavasis added this to the 1.8.7 release milestone Apr 26, 2024
@sgiavasis sgiavasis moved this from 👀 In review to Close on release in C-PAC Development Apr 26, 2024
@shnizzedy shnizzedy changed the title ✨ [User-requested Feature] Freesurfer-Ingress without data config ✨ Freesurfer-Ingress without data config Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Close on release
Development

No branches or pull requests

3 participants