Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ DRY "Gathering the output file paths from" in cpac_group_runner #2107

Open
shnizzedy opened this issue May 7, 2024 · 0 comments
Open

Comments

@shnizzedy
Copy link
Member

Not for this PR, but

# remove any extra /'s
pipeline_output_folder = pipeline_output_folder.rstrip("/")
logger.info(
"\n\nGathering the output file paths from %s...", pipeline_output_folder
)
# this is just to keep the fsl feat config file derivative_list entries
# nice and lean
dirs_to_grab = []
for derivative_name in derivative_list:
for resource_name in resource_list:
if resource_name in derivative_name:
dirs_to_grab.append(derivative_name)
and
# remove any extra /'s
pipeline_output_folder = pipeline_output_folder.rstrip("/")
logger.info(
"\n\nGathering the output file paths from %s...", pipeline_output_folder
)
# this is just to keep the fsl feat config file derivatives entries
# nice and lean
search_dirs = []
for derivative_name in derivatives:
for resource_name in resource_list:
if resource_name in derivative_name:
search_dirs.append(derivative_name)
could be DRY'd into a single function

Originally posted by @shnizzedy in #2062 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant