Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Always or by default have Function nodes "as module"s? #2109

Open
shnizzedy opened this issue May 7, 2024 · 0 comments
Open

♻️ Always or by default have Function nodes "as module"s? #2109

shnizzedy opened this issue May 7, 2024 · 0 comments

Comments

@shnizzedy
Copy link
Member

shnizzedy commented May 7, 2024

Why don't we default

as True (or even not make it an option, and just always have Function nodes "as module"s)?

I.e., when would we want a Function node not be "as module"?

Originally posted by @shnizzedy in #2062 (comment)

It's cool; as far as I can tell, it

  1. Includes the variables available in the namespace like if you imported the function normally outside of nipype (so you don't need the imports param or the imports defined in the function itself
  2. Includes the module name in the log instead of just the text of the function

But I don't know how much overhead this costs or saves, or what other considerations we should have about whether / when to use it

#2062 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant