Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for label #17 bugs #86

Closed
wants to merge 3 commits into from
Closed

Fixes for label #17 bugs #86

wants to merge 3 commits into from

Commits on Nov 1, 2022

  1. FATFS: Ensure VOLID searches return only those

    Part of a fix for [FDOS/label#17]
    andrewbird committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7cd7ddd View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. FATFS: Add special case for label creation

    Part of a fix for [FDOS/label#17]
    andrewbird committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    63c2e62 View commit details
    Browse the repository at this point in the history
  2. FATFS: Write volume label to the BPB too

    If the BPB is either v4.1 or v7 long, then its volume label field
    should be written.
    
    Note:
      This site https://jdebp.uk/FGA/bios-parameter-block.html suggests that
    it is perfectly valid to have a v7 long BPB with a FAT12 or FAT16
    filesystem, although more usually it's used for FAT32. However I can't
    see any confirmation of this elsewhere, haven't seen an example of this
    in the wild, and have no means of generating a test article. More
    importantly since we are writing to the filesystem, it's important to
    not have any false positives or we could cause corruption. So for now
    this combination, should it exist, will not be updated. See the
    discussion here dosemu2/fdpp#202.
    
    Part of a fix for [FDOS/label#17]
    andrewbird committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    106d4cd View commit details
    Browse the repository at this point in the history