-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory benchmark #186
Memory benchmark #186
Conversation
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
f6f3141
to
86687f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some suggestions here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @VladoLavor ! I made a few comments inline.
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I added a suggestion to make it easier to add new metrics
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks !
I have added a simple API memory benchmark/test.
Example output:
It measures 1k, 10k, 100k, and 1M APIs by default. A custom number of APIs can be tested with the
-api-num
parameter. Thresholds are pre-defined only for default values. The test runs theGetVersion
API, which can be called indefinitely.Signed-off-by: Vladimir Lavor vlavor@cisco.com