Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icepack merge #70

Merged
merged 63 commits into from Feb 11, 2021
Merged

Icepack merge #70

merged 63 commits into from Feb 11, 2021

Conversation

lzampier
Copy link
Collaborator

@lzampier lzampier commented Feb 9, 2021

Addition of the Icepack subroutines to the FESOM2 model. The old sea-ice structure is maintained as default.

@lzampier lzampier added the enhancement New feature or request label Feb 9, 2021
@lzampier lzampier self-assigned this Feb 9, 2021
@koldunovn
Copy link
Member

@lzampier Thanks a lot!
Just first simple comment - you have changed permissions for come of the files in config directory to 755 from 644. Any specific reason to do this?

@@ -43,6 +43,8 @@ elif [[ $LOGINHOST = bsc ]]; then
STRATEGY="bsc"
elif [[ $LOGINHOST =~ ^juwels[0-9][0-9].ib.juwels.fzj.de$ ]]; then
STRATEGY="juwels"
elif [[ $LOGINHOST =~ ^jwlogin[0-9][0-9].juwels$ ]]; then
STRATEGY="juwels"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to keep one for juwels, the shorter the better :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the second juwels case to allow an easy compilation on the login nodes. But I agree, it is not necessary.

@lzampier
Copy link
Collaborator Author

lzampier commented Feb 9, 2021

@lzampier Thanks a lot!
Just first simple comment - you have changed permissions for come of the files in config directory to 755 from 644. Any specific reason to do this?

No, no specific reason for that. You can retain the old permission level.

#module load Intel/2019.3.199-GCC-8.3.0 ParaStationMPI/5.4 imkl/2019.5.281
#export FC=mpifort CC=mpicc CXX=mpicxx
module load Intel/2019.3.199-GCC-8.3.0 ParaStationMPI/5.4 imkl/2019.5.281
export FC=mpifort CC=mpicc CXX=mpicxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we more happy with this settings?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately yes, for large mesh partitions (approximately >2000 CPUs) I have issues with IntelMPI when the communication structure is initialized by FESOM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep your version then as a default.

@koldunovn
Copy link
Member

@lzampier Thanks a lot!
Just first simple comment - you have changed permissions for come of the files in config directory to 755 from 644. Any specific reason to do this?

No, no specific reason for that. You can retain the old permission level.

Would be easier if you just put the permissions back in the PR :)

@@ -379,7 +409,7 @@ subroutine EVPdynamics_m(mesh)

if (a_ice(i) >= 0.01_WP) then
inv_thickness(i) = (rhoice*m_ice(i)+rhosno*m_snow(i))/a_ice(i)
inv_thickness(i) = 1.0_WP/max(inv_thickness(i), 9.0_WP) ! Limit the mass
inv_thickness(i) = 1.0_WP/inv_thickness(i) !max(inv_thickness(i), 9.0_WP) ! Limit the mass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we don't want to limit it?


asum=sum(a_ice(elnodes))*val3
!#if defined (__icepack)
! pressure_fac(el) = det2*sum(strength(elnodes))*val3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be commented out?

@@ -32,7 +32,7 @@ MODULE i_PARAM
real(kind=WP) :: theta_io=0.0_WP ! rotation angle
! (ice-ocean), available
! in EVP
real(kind=WP) :: alpha_evp=250, beta_evp=250
real(kind=WP) :: alpha_evp=500, beta_evp=500
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return to old default values for consistency. Now one can change this parameters in the namelist.io.

@koldunovn koldunovn merged commit 68d8b8b into master Feb 11, 2021
WiltonLoch pushed a commit to WiltonLoch/fesom2 that referenced this pull request Feb 1, 2023
@suvarchal suvarchal deleted the icepack_merge branch December 13, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants