Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMX/x87 interaction is subtly broken #3850

Closed
alyssarosenzweig opened this issue Jul 10, 2024 · 2 comments · Fixed by #4105
Closed

MMX/x87 interaction is subtly broken #3850

alyssarosenzweig opened this issue Jul 10, 2024 · 2 comments · Fixed by #4105

Comments

@alyssarosenzweig
Copy link
Collaborator

MMX is supposed to set the upper bits of the 80-bit x87 register to -1, and also supposed to set certain x87 flags. FEX isn't doing either. I don't know of any applications that rely on this behaviour, but Intel documents it explicitly.

@alyssarosenzweig
Copy link
Collaborator Author

see dca0906 for what prompted this. FEX is currently implicitly inserting without touching the upper bits, which is wrong. With that commit, FEX explicitly inserts and explicitly preserves the upper bits, which is slow and just as wrong.

@pmatos
Copy link
Collaborator

pmatos commented Sep 16, 2024

Due to a couple of other blockers, I might look into this earlier than I thought I would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants