Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added family name string to finite elments #62

Merged
merged 5 commits into from
Nov 19, 2020
Merged

Added family name string to finite elments #62

merged 5 commits into from
Nov 19, 2020

Conversation

mscroggs
Copy link
Member

Store the family name so this can be put in the FFC generated code then used by dolfin to reconstruct the element

@mscroggs mscroggs mentioned this pull request Nov 19, 2020
Closed
@chrisrichardson
Copy link
Contributor

Could we make the family name as the first argument to FiniteElement?

@chrisrichardson
Copy link
Contributor

How can we match this up with the code in util.cpp - we don't want to have the names appear twice.

@mscroggs
Copy link
Member Author

How can we match this up with the code in util.cpp - we don't want to have the names appear twice.

I found a way in 88d8c56

@chrisrichardson chrisrichardson merged commit 83ec4ed into master Nov 19, 2020
@chrisrichardson chrisrichardson deleted the mscroggs/family_strings branch November 19, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrichardson chrisrichardson Awaiting requested review from chrisrichardson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscroggs @chrisrichardson