Tidying up CMake files #118
Conversation
This could be adjusted to allow manual specifying UFC_DIR?
|
This is now ready to merge. MPI and PETSc are now required dependencies. This should make the build logic and the main code easier to read (no Regarding Python, I've wrapped some existing Python interpreter calls inside |
| @@ -34,13 +34,11 @@ if (NOT DOLFIN_USE_FILE_INCLUDED) | |||
| find_package(Boost 1.48 QUIET REQUIRED COMPONENTS | |||
There was a problem hiding this comment.
Maybe we should bump the required version to the minimum required for the Python bindings, which I think is 1.55.
|
UFC detection without Python sounds good (although we want to keep the Python detection for convenience). Maybe check |
There was a problem hiding this comment.
We also have docs which have to be updated https://fenicsproject.org/docs/dolfinx/dev/python/installation.html 😉
cpp/CMakeLists.txt
Outdated
| @@ -119,6 +116,11 @@ foreach (OPTIONAL_PACKAGE ${OPTIONAL_PACKAGES}) | |||
| add_feature_info(${OPTION_NAME} ${OPTION_NAME} "Compile with support for ${OPTIONAL_PACKAGE}.") | |||
| endforeach() | |||
|
|
|||
| # Required packages | |||
| # TODO: Remove #ifdef in code? | |||
| option("DOLFIN_ENABLE_PETSC" "Compile with support for PETSc." ON) | |||
I couldn't get Boost_VERSION to work (it outputs e.g. 105600 rather than 1.56).
No description provided.