Concatenating strings in a more portable way -- for some unclear reason

[massimiliano-leoni]

Normal string concatenation was observed to fail on some machines for unclear reasons. This implementation seems to be more robust.

[jhale]

This is unexpected! It would be nice to have a bit of clarity on why this happens before continuing though. What C++ standard library version are you building against?

[michalhabera]

This depends on the filesystem library which provides the filename string. It would be good to first understand the issue more. We could just use C++17 stdlib filesystem then.

[massimiliano-leoni]

This is unexpected! It would be nice to have a bit of clarity on why this happens before continuing though. What C++ standard library version are you building against?

On this machine I believe I'm using libstdc++.so.6.0.28, provided by GCC 10.2.0.

[garth-wells]

I don't think we can merge this without a clear understanding of what the cause is, and with very clear comments on it. The current code look perfectly compliant to me.

[garth-wells]

@massimiliano-leoni Does https://stackoverflow.com/a/59823692 help? (adding s)

[massimiliano-leoni]

@garth-wells I tried but I couldn't get it to compile, I'm getting some error I don't fully understand.

[garth-wells]

Not reproducible, so closing.