Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store coordinate element in ufc_form #409

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Store coordinate element in ufc_form #409

merged 6 commits into from
Nov 10, 2021

Conversation

mscroggs
Copy link
Member

Fixes #406.

@mscroggs mscroggs marked this pull request as draft October 28, 2021 10:50
@mscroggs mscroggs marked this pull request as ready for review October 28, 2021 11:01
@mscroggs mscroggs mentioned this pull request Oct 28, 2021
Closed
garth-wells
garth-wells reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should some tests be added?

@michalhabera
Copy link
Contributor

I think it would make more sense to store it in ufc_integral. There are several integrals per form and each integral could have domain of different coordinate element - especially towards transition to mixed topology. Also, shouldn't ufc_dofmap be attached too (maybe some form of "function space")?

@garth-wells garth-wells merged commit 4d3b540 into main Nov 10, 2021
@garth-wells garth-wells deleted the mscroggs/ufc_coordinate_element branch November 10, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garth-wells garth-wells garth-wells approved these changes

@michalhabera michalhabera michalhabera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add geometry element to ufc_form
4 participants
@mscroggs @michalhabera @garth-wells @IgorBaratta