-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and extend ufc_expression #432
Conversation
@@ -39,7 +39,7 @@ def iter_indented_lines(snippets, level=0): | |||
- tuple,list: Yield lines from recursive application of this function to list items. | |||
|
|||
""" | |||
tabsize = 4 | |||
tabsize = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is unrelated, but makes complicated kernels more readable.
Isn't this PR missing |
This is responsibility of kernel caller, right? My understanding is dof transformations would be called in dolfinx after tabulation kernel. But I did not add any example which would |
Sorry, I put this comment on the wrong PR, was meant for the dolfinx one. |
…michal/expressions-cpp
This PR updates signature for
ufc_expression
tabulation kernel to useufc_tabulate_tensor_float32
,ufc_tabulate_tensor_float64
, etc. (shared signature withufc_form
).More information is added to ufc_expression to allow rank-1 expressions in dolfinx, i.e. Expressions containing UFL Argument. This is useful to build point-wise operators, see dolfinx PR.