Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and extend ufc_expression #432

Merged
merged 38 commits into from
Feb 3, 2022
Merged

Update and extend ufc_expression #432

merged 38 commits into from
Feb 3, 2022

Conversation

michalhabera
Copy link
Contributor

This PR updates signature for ufc_expression tabulation kernel to use ufc_tabulate_tensor_float32, ufc_tabulate_tensor_float64, etc. (shared signature with ufc_form).

More information is added to ufc_expression to allow rank-1 expressions in dolfinx, i.e. Expressions containing UFL Argument. This is useful to build point-wise operators, see dolfinx PR.

@@ -39,7 +39,7 @@ def iter_indented_lines(snippets, level=0):
- tuple,list: Yield lines from recursive application of this function to list items.

"""
tabsize = 4
tabsize = 2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated, but makes complicated kernels more readable.

@jorgensd
Copy link
Member

jorgensd commented Dec 1, 2021

Isn't this PR missing apply_dof_transformations for the more exotic finite elements (N1 curl, N1 div)?

@michalhabera
Copy link
Contributor Author

Isn't this PR missing apply_dof_transformations for the more exotic finite elements (N1 curl, N1 div)?

This is responsibility of kernel caller, right? My understanding is dof transformations would be called in dolfinx after tabulation kernel. But I did not add any example which would needs_facet_permutations == True into dolfinx tests yet.

@jorgensd
Copy link
Member

jorgensd commented Dec 1, 2021

Isn't this PR missing apply_dof_transformations for the more exotic finite elements (N1 curl, N1 div)?

This is responsibility of kernel caller, right? My understanding is dof transformations would be called in dolfinx after tabulation kernel. But I did not add any example which would needs_facet_permutations == True into dolfinx tests yet.

Sorry, I put this comment on the wrong PR, was meant for the dolfinx one.

@jhale jhale merged commit ac713eb into main Feb 3, 2022
@jhale jhale deleted the michal/expressions-cpp branch February 3, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants