Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use float type that matches scalar type #502

Merged
merged 18 commits into from
Jun 24, 2022
Merged

Use float type that matches scalar type #502

merged 18 commits into from
Jun 24, 2022

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Jun 23, 2022

Previously double was used for basis functions and geometry. This eliminated performance benefits of using reduced precision for the fields. This change uses the same float type as for the fields.

See also FEniCS/dolfinx#2252.

Copy link
Member

@IgorBaratta IgorBaratta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garth-wells garth-wells merged commit 4f7dced into main Jun 24, 2022
@garth-wells garth-wells deleted the garth/geom-type branch June 24, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants