Fix bug that led to Quadrature Elements not being blocked. #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhale
commented
Jul 10, 2023
jhale
changed the title
|
I've figured out how to construct the element with modern FFCx and Basix element constructors (rather than UFL) so I'll make that change first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the logic in element_interface.py led to the built in FFCx type QuadratureElement always being handled
prior to the call to Basix's block element. This PR changes this to handle elements in order of higher-order types, FFCx types, and then finally UFL types.
It's not clear to be what the modern 'basix' way to handle QuadratureElements might be (regarding the warning).