Remove switch/case from generated code #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cx into chris/remove-switch-case
jorgensd
reviewed
Aug 15, 2023
|
|
||
| default_integral = form0.integrals(module.lib.exterior_facet)[0] | ||
| default_integral = form0.form_integrals[integral_offsets[ex]] |
There was a problem hiding this comment.
This here is implicitly tied to the ordering of the enum in DOLFINx, which I'm not sure is a good idea. See: #589 (comment)
There was a problem hiding this comment.
The order is explicitly defined in ufcx.h
There was a problem hiding this comment.
It is still an issue for whenever we generate the offsets (as that is based on strings in a for-loop, not the enum).
There was a problem hiding this comment.
I have annotated the point where this happens in ffcx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the function interfaces in ufcx for entity_dofs and form integrals, which are replaced with static data.