Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zero Lexpr check #701

Merged
merged 2 commits into from
May 29, 2024
Merged

Remove zero Lexpr check #701

merged 2 commits into from
May 29, 2024

Conversation

jorgensd
Copy link
Member

Closing #699

Copy link
Contributor

@michalhabera michalhabera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the docstring to not mention zero simplification. Maybe add an issue for future work that there is this zero simplification opportunity.

@jorgensd jorgensd enabled auto-merge May 29, 2024 18:54
@jorgensd jorgensd added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit d324f38 May 29, 2024
13 checks passed
@jorgensd jorgensd deleted the dokken/float_product_zeros branch May 29, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiteralFloat with value Zero not supported in compilation of integral
2 participants