Remove geometric dimension from cell, move value_shape to FunctionSpace #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2024
mscroggs
changed the title
garth-wells
approved these changes
Feb 8, 2024
|
@mscroggs is this ready to merge? I don't want to try ruff/black formatting before this PR is wrapped up. |
Ran out of time to sort this today. I'll update the coupled PRs and get this merged over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element needed to know the geometric domain to know the physical value size. With the value size functions moved to FunctioSpace, the geometric domain can instead be obtained from the mesh/domain and the cell no longer needs a gdim.
This PR moves toward these aims that I propose that we follow:
CellandFiniteElementcan always be thought of as the reference cell and element defined on the reference cellMeshobject)Coupled with FEniCS/basix#772, FEniCS/ffcx#653, FEniCS/dolfinx#2996.
The draft changes in FInAT/FInAT#118 and firedrakeproject/tsfc#307 will be needed once this is merged into Firedrake's fork of UFL.