Performance improvements for transformations #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
map_expr_dags
to reuse the result cache across calls. This makes a big difference in applying restrictions and derivatives, which have a dispatch rule that callsmap_expr_dag
that previously would not cache across calls into subtrees.I am pretty sure that they are correct, but will run the Firedrake test suite to check for regressions.
Representative timing data for the below script
Before:
After eager DAGifying:
Reusing caches in apply restrictions
With all changes: