Remove fastmail.fm provider as it is legitimate #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept fastmail.fm emails Conflicts: platform/ruby/mail_checker.rb
|
Fixed in v1.5.1 :) |
|
@FGRibreau thanks! I would be cool if you could cherry-pick the changes next time so I would appear in the "Contributors" section. 😄 No big deal. |
|
@kennym indeed, I'm sorry! I intentionally did my own PR to remove fastmail.fm in order to be sure that no other domain were removed, what line should I add inside the "contributor" section in package.json? |
|
I am referring to this section: https://github.com/FGRibreau/mailchecker/graphs/contributors |
|
Oh I see, I'm sorry, I won't be able to do this soon but if you find any other issue related to mailchecker, be sure I will merge it instantanely! I'm really sorry for the inconvenience :( |
|
@FGRibreau no inconvenience at all! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have active users with our product with that email provider, and they're legitimate users. Also fastmail.fm doesn't offer you to create disposable emails.