Skip to content

Commit 031a143

Browse files
committed
Upgraded request, callback is now optional
1 parent c31eca0 commit 031a143

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ Install with [npm](https://npmjs.org/package/requestretry).
3737

3838
## Changelog
3939

40+
v1.0.2
41+
42+
- upgraded `request` to 2.44.0 (19/09/2014)
43+
- callback is now optional
44+
45+
v1.0.1:
46+
47+
- added `cancelable` as deps
48+
4049
v1.0.0: request now yield an Request instance with a `.abort()` method.
4150
v0.0.1: Initial commit
4251

index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ Request.prototype.abort = function(){
5656
};
5757

5858
function Factory(options, f){
59+
f = _.isFunction(f) ? f : _.noop;
5960
var retry = _(options || {}).defaults(DEFAULTS).pick(Object.keys(DEFAULTS)).value();
6061
var req = new Request(options, f, retry.maxAttempts, retry.retryDelay);
6162
req._tryUntilFail();

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
"main": "index.js",
1414
"license": "MIT",
1515
"dependencies": {
16+
"cancelable": "~0.1.0",
1617
"fg-lodash": "0.0.1",
17-
"request": "~2.34.0",
18-
"cancelable": "~0.1.0"
18+
"request": "~2.44.0"
1919
},
2020
"devDependencies": {
2121
"chai": "~1.9.1",

0 commit comments

Comments
 (0)